Jump to content


Photo

[Resto] TreeCalcs


  • Please log in to reply
187 replies to this topic

#41 Hamlet

Hamlet

    Mike Tyson

  • • Guide Author
  • 11,540 posts

Posted 11 June 2011 - 08:20 AM

Some updates for Harmony and set bonuses.

Attached Files



#42 Hamlet

Hamlet

    Mike Tyson

  • • Guide Author
  • 11,540 posts

Posted 12 June 2011 - 08:44 PM

By the way, this Treecalcs is basically ready for a gear update--I think I put in everything I wanted to besides trinkets.

#43 Tecton

Tecton

    Soda Popinski

  •  Patrons
  • 3,946 posts

Posted 13 June 2011 - 10:12 AM

Updated with gear + ilvl cutoff on the front sheet.

Please note: I haven't had time to update the profile functionality of this version. Please don't use it for now. If anything else isn't working as expected, please let me know.

Attached Files



#44 Hamlet

Hamlet

    Mike Tyson

  • • Guide Author
  • 11,540 posts

Posted 15 June 2011 - 07:36 AM

Trinkets added, including estimates for Eye/Jaws. Also, TreeCalcs now has the haste overhaul that WrathCalcs got a while ago (i.e., it actually computes all HoT breakpoints independently for all temporary haste buffs and then averages them together). I figered I'd add it in here, since we're likely to be using Shard of Woe for a while, and in general there are a lot of gearing issues surrounding haste breakpoints.

Still need to throw the Nourish bonus in there in some way.

Attached Files



#45 Hamlet

Hamlet

    Mike Tyson

  • • Guide Author
  • 11,540 posts

Posted 08 July 2011 - 06:30 AM

Put an update on the main thread with the WG fix. Also added a socket to Flickering Shoulderpads, deleted duplicate Flickering Shoulderpads entry, and deleted Flickering Wristguards (since it can't have Int suffixes).

#46 Nihlo

Nihlo

    Von Kaiser

  • Members
  • 65 posts

Posted 08 July 2011 - 09:01 AM

I wonder if you underestimated the in your spreadsheet. You can find all information you need at the wowhead comments or in the Gear Discussion Thread. For example it can crit for 32k.

#47 Hamlet

Hamlet

    Mike Tyson

  • • Guide Author
  • 11,540 posts

Posted 08 July 2011 - 09:10 AM

By all information I've gotten it doesn't scale with spellpower, and it has a 45s ICD--these are the only two things that could really have made a big difference. I'll add in the fact that it can crit and the 4% from MSS, but those aren't going to have a huge impact on its value.

e: added that in the sheet though.

#48 Ultis

Ultis

    Von Kaiser

  • Members
  • 29 posts

Posted 15 July 2011 - 05:51 PM

For example it can crit for 32k.


Interesting, fixed that in Rawr.Tree (according to TreeCalcs, it's also affected by Master Shapeshifter and Tree of Life).

It's not affected by Harmony, right?

#49 Hamlet

Hamlet

    Mike Tyson

  • • Guide Author
  • 11,540 posts

Posted 15 July 2011 - 06:02 PM

Mmm, doubt it. Additive buffs like Harmony usually apply to an enumerated list of spells.

#50 LordAnxiety

LordAnxiety

    Glass Joe

  • Members
  • 9 posts

Posted 17 July 2011 - 11:02 PM

First of all I ll say Thank you so much for your work Hamlet.

As I m using Exel 2007 I like to use the macros. So I discovered that after a "profileload" in the sheet "Main" that there are some problems. First I will only post a Bug Report, but then I decide to change it.

So what I did:
In the "LoadProfile" macro there was a misconfiguration of the Elements.

So here are the changes I put into Module2.profileload:

Range("NG") = Sheets("Profiles").Range(startcolumn & "22").Offset(0, 1)
Rem Range("C4") = Sheets("Profiles").Range(startcolumn & "22").Offset(0, 1)
Range("Nat_Maj") = Sheets("Profiles").Range(startcolumn & "23").Offset(0, 1)
Rem Range("C5") = Sheets("Profiles").Range(startcolumn & "23").Offset(0, 1)
Range("Genesis") = Sheets("Profiles").Range(startcolumn & "24").Offset(0, 1)
Rem Range("C6") = Sheets("Profiles").Range(startcolumn & "24").Offset(0, 1)
Range("Moonglow") = Sheets("Profiles").Range(startcolumn & "25").Offset(0, 1)
Rem Range("C7") = Sheets("Profiles").Range(startcolumn & "25").Offset(0, 1)

Range("Furor") = Sheets("Profiles").Range(startcolumn & "26").Offset(0, 1)
Rem Range("C9") = Sheets("Profiles").Range(startcolumn & "26").Offset(0, 1)

Range("BotG") = Sheets("Profiles").Range(startcolumn & "27").Offset(0, 1)
Rem Range("C11") = Sheets("Profiles").Range(startcolumn & "27").Offset(0, 1)
Range("Natural_SS") = Sheets("Profiles").Range(startcolumn & "28").Offset(0, 1)
Rem Range("C12") = Sheets("Profiles").Range(startcolumn & "28").Offset(0, 1)
Range("Naturalist") = Sheets("Profiles").Range(startcolumn & "29").Offset(0, 1)
Rem Range("C13") = Sheets("Profiles").Range(startcolumn & "29").Offset(0, 1)
Range("HotW") = Sheets("Profiles").Range(startcolumn & "30").Offset(0, 1)
Rem Range("C14") = Sheets("Profiles").Range(startcolumn & "30").Offset(0, 1)
Range("Perseverance") = Sheets("Profiles").Range(startcolumn & "31").Offset(0, 1)
Rem Range("C15") = Sheets("Profiles").Range(startcolumn & "31").Offset(0, 1)
Range("Master_SS") = Sheets("Profiles").Range(startcolumn & "32").Offset(0, 1)
Rem Range("C16") = Sheets("Profiles").Range(startcolumn & "32").Offset(0, 1)
Range("BoP") = Sheets("Profiles").Range(startcolumn & "33").Offset(0, 1)
Rem Range("C17") = Sheets("Profiles").Range(startcolumn & "33").Offset(0, 1)
Range("Liv_Seed") = Sheets("Profiles").Range(startcolumn & "34").Offset(0, 1)
Rem Range("C18") = Sheets("Profiles").Range(startcolumn & "34").Offset(0, 1)
Range("Revitalize") = Sheets("Profiles").Range(startcolumn & "35").Offset(0, 1)
Rem Range("C19") = Sheets("Profiles").Range(startcolumn & "35").Offset(0, 1)
Range("Nat_Swiftness") = Sheets("Profiles").Range(startcolumn & "36").Offset(0, 1)
Rem Range("C20") = Sheets("Profiles").Range(startcolumn & "36").Offset(0, 1)
Range("FoS") = Sheets("Profiles").Range(startcolumn & "37").Offset(0, 1)
Rem Range("C21") = Sheets("Profiles").Range(startcolumn & "37").Offset(0, 1)
Range("Nat_Bounty") = Sheets("Profiles").Range(startcolumn & "38").Offset(0, 1)
Rem Range("C22") = Sheets("Profiles").Range(startcolumn & "38").Offset(0, 1)
Range("Emp_Touch") = Sheets("Profiles").Range(startcolumn & "39").Offset(0, 1)
Rem Range("C23") = Sheets("Profiles").Range(startcolumn & "39").Offset(0, 1)
Range("Mal_Gift") = Sheets("Profiles").Range(startcolumn & "40").Offset(0, 1)
Rem Range("C24") = Sheets("Profiles").Range(startcolumn & "40").Offset(0, 1)
Range("Efflorescence") = Sheets("Profiles").Range(startcolumn & "41").Offset(0, 1)
Rem Range("C25") = Sheets("Profiles").Range(startcolumn & "41").Offset(0, 1)
Range("WG") = Sheets("Profiles").Range(startcolumn & "42").Offset(0, 1)
Rem Range("C26") = Sheets("Profiles").Range(startcolumn & "42").Offset(0, 1)
Range("Nat_Cure") = Sheets("Profiles").Range(startcolumn & "43").Offset(0, 1)
Rem Range("C27") = Sheets("Profiles").Range(startcolumn & "43").Offset(0, 1)
Range("Nat_Ward") = Sheets("Profiles").Range(startcolumn & "44").Offset(0, 1)
Rem Range("C28") = Sheets("Profiles").Range(startcolumn & "44").Offset(0, 1)
Range("GotEM") = Sheets("Profiles").Range(startcolumn & "45").Offset(0, 1)
Rem Range("C29") = Sheets("Profiles").Range(startcolumn & "45").Offset(0, 1)
Range("Swift_Rejuv") = Sheets("Profiles").Range(startcolumn & "46").Offset(0, 1)
Rem Range("C30") = Sheets("Profiles").Range(startcolumn & "46").Offset(0, 1)
Range("ToL") = Sheets("Profiles").Range(startcolumn & "47").Offset(0, 1)
Rem Range("C31") = Sheets("Profiles").Range(startcolumn & "47").Offset(0, 1)

Range("EfflorescenceHits") = Sheets("Profiles").Range(startcolumn & "73").Offset(0, 1)
Rem Range("H29") = Sheets("Profiles").Range(startcolumn & "73").Offset(0, 1)
Range("M23") = Sheets("Profiles").Range(startcolumn & "74").Offset(0, 1)
Rem Range("H30") = Sheets("Profiles").Range(startcolumn & "74").Offset(0, 1)
Range("M24") = Sheets("Profiles").Range(startcolumn & "75").Offset(0, 1)
Rem Range("H31") = Sheets("Profiles").Range(startcolumn & "75").Offset(0, 1)
Range("M25") = Sheets("Profiles").Range(startcolumn & "76").Offset(0, 1)
Rem Range("H32") = Sheets("Profiles").Range(startcolumn & "76").Offset(0, 1)
Range("M26") = Sheets("Profiles").Range(startcolumn & "77").Offset(0, 1)
Rem Range("H33") = Sheets("Profiles").Range(startcolumn & "77").Offset(0, 1)
Range("M27") = Sheets("Profiles").Range(startcolumn & "78").Offset(0, 1)
Rem Range("H34") = Sheets("Profiles").Range(startcolumn & "78").Offset(0, 1)
Range("M28") = Sheets("Profiles").Range(startcolumn & "79").Offset(0, 1)
Rem Range("H35") = Sheets("Profiles").Range(startcolumn & "79").Offset(0, 1)
Range("M29") = Sheets("Profiles").Range(startcolumn & "80").Offset(0, 1)
Rem Range("H36") = Sheets("Profiles").Range(startcolumn & "80").Offset(0, 1)

Rem Range("J30") = Sheets("Profiles").Range(startcolumn & "81").Offset(0, 1)
Rem Range("J31") = Sheets("Profiles").Range(startcolumn & "82").Offset(0, 1)
Rem Range("J32") = Sheets("Profiles").Range(startcolumn & "83").Offset(0, 1)
Rem Range("J33") = Sheets("Profiles").Range(startcolumn & "84").Offset(0, 1)
Rem Range("J34") = Sheets("Profiles").Range(startcolumn & "85").Offset(0, 1)
Rem Range("J35") = Sheets("Profiles").Range(startcolumn & "86").Offset(0, 1)

Range("InstantDelay") = Sheets("Profiles").Range(startcolumn & "90").Offset(0, 1)
Rem Range("M11") = Sheets("Profiles").Range(startcolumn & "90").Offset(0, 1)
Range("AstralLeather") = Sheets("Profiles").Range(startcolumn & "91").Offset(0, 1)
Rem Range("M18") = Sheets("Profiles").Range(startcolumn & "91").Offset(0, 1)
Range("Bloodlust") = Sheets("Profiles").Range(startcolumn & "95").Offset(0, 1)
Rem Range("M28") = Sheets("Profiles").Range(startcolumn & "95").Offset(0, 1)

The lines starting with "Rem " are the original ones I commented out. Don't know if this works in every Exel Version.

I have a problem wit the 6 lines starting with J30 to J35 because I don't know where to put them. In the sheet "Profiles" (hidden) they named in the "Hamlet T12" profile Range J81:J86 : Rejuv, HT, Nourish, LB, WG, RG
I search after the place to put them but I can't find it. So I commented out that lines to prevent to overwrite the calculations.

After that fix, I discover that there is also a problem with the profile saving (TalentSpecs are not placed correctly). The bug is sitting in the sheet "ProfileTemplate". These sheet I also fixed based on TreeCalcs110707.xls .

The fixed sheet you can find on my Skydrive rep: https://skydrive.liv...A302DC0720C!117

The file named TreeCalcs 110707-with-fixed-macro.loadprofile.alpha.xls

I hope I could help you.

P.S.: If everything I changed is okay for you I can clear the macro code and send you then the fixed file.

P.P.S.: Hopefully that you can understand me. I m not a english native speaker and my understand is much better than my wirting.

#51 Tecton

Tecton

    Soda Popinski

  •  Patrons
  • 3,946 posts

Posted 18 July 2011 - 12:08 AM

Yeah, I posted earlier that the profile system hadn't been updated for Treecalcs yet (there were some layout changes/etc). With a bit of help from Landsoul I'm in the process of updating this to include armory import (finally, I know) and forgot to get this working in the interim.

#52 Hamlet

Hamlet

    Mike Tyson

  • • Guide Author
  • 11,540 posts

Posted 18 July 2011 - 07:51 PM

Yeah, I posted earlier that the profile system hadn't been updated for Treecalcs yet (there were some layout changes/etc). With a bit of help from Landsoul I'm in the process of updating this to include armory import (finally, I know) and forgot to get this working in the interim.


By the way, does this mean you're planning some big transplant into the sheet at some point soon?

#53 Tecton

Tecton

    Soda Popinski

  •  Patrons
  • 3,946 posts

Posted 18 July 2011 - 09:04 PM

I'll give you a shout for your latest version before I add anything, I can copy and paste everything across without a problem. Hopefully be within the next week or so.

#54 Unravel

Unravel

    Piston Honda

  • Members
  • 217 posts

Posted 20 July 2011 - 10:43 AM

The haste rating calculation includes averaged haste bonuses from professions (e.g. Herbalism), which threw for a loop when paper-dolling for the 2005 haste-breakpoint.
Also, the loading of saved profiles seems broken, I end up with RG displayed in the HPS column and a non-working spreadsheet.

The gear and enchant selection is really nice.

#55 Tecton

Tecton

    Soda Popinski

  •  Patrons
  • 3,946 posts

Posted 20 July 2011 - 10:47 AM

Yeah, I'll be uploading a fix for profiles shortly, mildly swamped right now.

Hamlet has a seperate page for temporary haste, I think herbalism might have been overlooked though. Good catch!

[edit]

Templates should be working on this version, if I've missed anything please post up. If you want to resolve the herbalism haste cap problem for now, you should probably just put -80 under the haste manual adjustment while making your changes until it's sorted elsewhere. Not perfect, I know.

Attached Files



#56 LordAnxiety

LordAnxiety

    Glass Joe

  • Members
  • 9 posts

Posted 20 July 2011 - 12:11 PM

Only a shrot reply.

Tecton it don't can test extremly if the macros work. But what I see is that you missed in my post that the Sheet "ProfilesTemplate", espacially the talent saving there ist broken too. Look at ProfilesTemplate!$B22:$B47 in my sheet. There you'll find the fix for this problem.

Hopefully this help you.

I m on the way to holiday now. Hopefully seen back with another wonderfull work. ;)

#57 Tecton

Tecton

    Soda Popinski

  •  Patrons
  • 3,946 posts

Posted 20 July 2011 - 01:23 PM

Everything seems to be working fine in that last version as far as I can see, is it putting anything in the wrong place?

#58 LordAnxiety

LordAnxiety

    Glass Joe

  • Members
  • 9 posts

Posted 20 July 2011 - 01:41 PM

Jup,

that is what it is doing.

As you look at sheet "Main". There you have between the different talent trees one free cell. In the sheet "ProfileTemplate" the references are going from Main!C4: Main!C31, but cell Main!C26=WG is not there and WG is referenced to Main!C25. The same with Efflorescence with is Main!C25=Efflorescence is referenced to Main!C23. I think is comes from a change of the talent tree order in Main.

Also in my sheet I have already referenced all that directly to the name not only to the cell, because maybe there are changes in future and to avoid a thing like this, a reference to name is better than only to the cell.

Hopefully you can open my treecalcs.

#59 Nihlo

Nihlo

    Von Kaiser

  • Members
  • 65 posts

Posted 20 July 2011 - 01:56 PM

By the way if you improve Hamlet's file, 110714 was his latest file not the 110707. You can find it here:
http://elitistjerks....p3/#post1967508
just a few trinkets adjustments.

#60 Erdluf

Erdluf

    Great Tiger

  • Members
  • 960 posts

Posted 27 July 2011 - 12:22 PM

It looks like somewhere along the line (perhaps during the Symbiosis->Harmony conversion?), TreeCalcs dropped Nourish's 20% bonus.

I think that by default, TC should assume that Nourish gets the bonus.




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users