Jump to content


Photo

Deepwind Gorge


  • Please log in to reply
7 replies to this topic

#1 Resike

Resike

    Glass Joe

  • Members
  • 17 posts

Posted 18 December 2013 - 02:42 PM

Deepwind Gorge is still missing from the PVP module.



#2 MysticalOS

MysticalOS

    French Hacker

  • ♦ Administrators
  • 940 posts
  • LocationGeorgia

Posted 18 December 2013 - 03:56 PM

Yes. I don't typically do the pvp mods, and the person who does has been on absence from wow. I'll see if I can get him some game time in the future to work on that.



#3 Resike

Resike

    Glass Joe

  • Members
  • 17 posts

Posted 23 December 2013 - 08:55 AM

Well i would gladly maintain that module, since i only do pvp, if he won't be able to do it.



#4 Cenuij

Cenuij

    Glass Joe

  • Members
  • 14 posts

Posted 16 June 2014 - 12:21 PM

I've been working on a proof of concept Deepwind Gorge module (cribbed from the AB one).
I've got the cap timers and a first cut of the win timer working.
 
What's the best way to get the code contributed back to subversion repo?
 
 
Edit: Win timers working.

#5 MysticalOS

MysticalOS

    French Hacker

  • ♦ Administrators
  • 940 posts
  • LocationGeorgia

Posted 16 June 2014 - 06:03 PM

You could just pastebin the lua from the module and then post a link here so I can review it.

#6 Cenuij

Cenuij

    Glass Joe

  • Members
  • 14 posts

Posted 17 June 2014 - 07:51 AM

svn diff: http://pastebin.com/hW1qqCRV

 

Raw source of the new module: http://pastebin.com/zGEWjUed

 

 

Arguably a chunk of the PVP mods could be refactored to share common functionality (e.g, winTimer support), but that's a separate effort.

 

I haven't done the localisation cut&paste for non-EN.


Edited by Cenuij, 17 June 2014 - 07:51 AM.


#7 MysticalOS

MysticalOS

    French Hacker

  • ♦ Administrators
  • 940 posts
  • LocationGeorgia

Posted 17 June 2014 - 08:28 AM

That diff is in revision 31 of pvp mods. I can probably see about getting you proper svn access to continue working on pvp mods if you wish.

#8 Cenuij

Cenuij

    Glass Joe

  • Members
  • 14 posts

Posted 18 June 2014 - 03:21 AM

Thanks for adding it.

 

I'll follow up formal access next week - I'm AFK for a few days from today.






0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users