Jump to content


Photo

SimulationCraft - S(t)imulating your inner rage


  • This topic is locked This topic is locked
95 replies to this topic

#41 jlassila

jlassila

    Glass Joe

  • Members
  • 4 posts

Posted 19 April 2009 - 07:24 PM

Ok, I just wasn't using the T8 globals file, silly me. Here's what I get with your original and my "better" arms spec, including the imp.execute change I outlined above. Seems that the heroic strike critting has a bigger impact than imp.exec. I wonder if something is wrong or if that is really how it is.


SimulationCraft for World of Warcraft build 3.1.0 (iterations=1000, max_time=300, optimal_raid=1)

DPS Ranking:
  16443 100.0%  Raid
   5627  34.2%  Warrior_T7_18_53_00
   5439  33.0%  Warrior_T7_MS_Orig
   5398  32.8%  Warrior_T7_MS_2ptImpExec

Player=Warrior_T7_18_53_00  DPS=5627.2 (Error=+/-12.7 Range=+/-695)  DPR=345.2  RPS=16.3/16.4  (rage)
  Core Stats:  strength=687  agility=713  stamina=1263  intellect=41  spirit=71  health=17029  mana=20
  Spell Stats:  power=0  hit=6.3%  crit=21.0%  penetration=0  haste=8.4%  mp5=0
  Attack Stats:  power=3571  hit=5.0%  crit=35.6%  expertise=4.5  penetration=17.9  haste=8.4%
  Defense Stats:  armor=1426
  Actions:
    bloodthirst           Count= 49.6| 5.9sec  DPE= 5243|15%  DPET= 3177  DPR= 174.8  Miss=0.0%  Hit=3204  Crit= 7287|10650|51.5%  Dodge=2.0%
    deep_wounds           Count=  0.0| 0.0sec  DPE=    1|15%  DPET=    1  DPR=   0.0  Miss=-1.$%  TickCount=215  Tick=1215
    execute               Count= 14.0| 3.1sec  DPE= 8207| 7%  DPET= 4974  DPR= 113.9  Miss=0.0%  Hit=4874  Crit=11195|14766|54.3%  Dodge=2.0%
    heroic_strike         Count= 98.3| 2.7sec  DPE= 4010|23%  DPET=    1  DPR= 334.2  Miss=0.0%  Hit=2447  Crit= 5568| 7396|51.7%  Dodge=2.0%
    melee_main_hand       Count= 37.0| 8.2sec  DPE= 2708| 6%  DPET= 1412  DPR=   0.0  Miss=19.0%  Hit=2122  Crit= 4358| 5742|51.9%  Glance=1583|24.1%  Dodge=1.9%
    melee_off_hand        Count=133.9| 2.2sec  DPE= 1655|13%  DPET=  819  DPR=   0.0  Miss=18.8%  Hit=1286  Crit= 2652| 3590|52.3%  Glance= 966|24.0%  Dodge=2.0%
    slam                  Count= 18.7|14.5sec  DPE= 4395| 5%  DPET= 2664  DPR= 293.0  Miss=0.0%  Hit=2689  Crit= 6121| 8243|51.2%  Dodge=1.9%
    whirlwind             Count= 71.0| 8.4sec  DPE= 3514|15%  DPET= 4259  DPR= 281.1  Miss=0.0%  Hit=2125  Crit= 4808| 8054|53.3%  Dodge=2.0%

Player=Warrior_T7_MS_2ptImpExec  DPS=5398.3 (Error=+/-8.9 Range=+/-506)  DPR=424.1  RPS=12.7/12.8  (rage)
  Core Stats:  strength=1103  agility=487  stamina=1314  intellect=41  spirit=71  health=17534  mana=20
  Spell Stats:  power=0  hit=9.8%  crit=20.4%  penetration=0  haste=6.4%  mp5=0
  Attack Stats:  power=3965  hit=7.8%  crit=31.3%  expertise=6.8  penetration=0.0  haste=6.4%
  Defense Stats:  armor=974
  Actions:
    bladestorm            Count=  4.0|91.1sec  DPE=21069| 5%  DPET= 3370  DPR= 842.8  Miss=0.0%  TickCount=28  Tick=1916  CritTick=4146|4253|49.1%
    deep_wounds           Count=  0.0| 0.0sec  DPE=    1|15%  DPET=    1  DPR=   0.0  Miss=-1.$%  TickCount=211  Tick=1178
    execute               Count= 18.0|15.5sec  DPE= 6610| 7%  DPET= 4007  DPR= 133.3  Miss=0.1%  Hit=3916  Crit= 9376|13327|49.4%
    heroic_strike         Count= 23.1|10.8sec  DPE= 3993| 6%  DPET=    1  DPR= 332.8  Miss=0.2%  Hit=2380  Crit= 5701| 5806|48.7%
    melee_main_hand       Count= 92.0| 3.3sec  DPE= 2968|17%  DPET= 1276  DPR=   0.0  Miss=0.2%  Hit=1962  Crit= 4245| 4340|49.4%  Glance=1472|24.0%
    mortal_strike         Count= 43.3| 6.8sec  DPE= 4562|12%  DPET= 2765  DPR= 152.1  Miss=0.2%  Hit=2694  Crit= 6453| 6572|49.8%
    overpower             Count= 46.7| 6.3sec  DPE= 5504|16%  DPET= 4787  DPR=1100.7  Miss=0.2%  Hit=2316  Crit= 5535| 5653|99.1%
    rend                  Count= 14.0|21.7sec  DPE= 7903| 7%  DPET= 4790  DPR= 790.3  Miss=0.1%  TickCount=96  Tick=1152
    slam                  Count= 57.9| 4.2sec  DPE= 4028|14%  DPET= 2442  DPR= 268.5  Miss=0.1%  Hit=2390  Crit= 5725| 5842|49.2%

Player=Warrior_T7_MS_Orig  DPS=5438.6 (Error=+/-8.5 Range=+/-388)  DPR=428.8  RPS=12.7/12.8  (rage)
  Core Stats:  strength=1103  agility=487  stamina=1314  intellect=41  spirit=71  health=17534  mana=20
  Spell Stats:  power=0  hit=9.8%  crit=20.4%  penetration=0  haste=6.4%  mp5=0
  Attack Stats:  power=3965  hit=7.8%  crit=31.3%  expertise=6.8  penetration=0.0  haste=6.4%
  Defense Stats:  armor=974
  Actions:
    bladestorm            Count=  4.0|91.1sec  DPE=21117| 5%  DPET= 3378  DPR= 844.7  Miss=0.0%  TickCount=28  Tick=1916  CritTick=4145|4253|49.5%
    deep_wounds           Count=  0.0| 0.0sec  DPE=    1|16%  DPET=    1  DPR=   0.0  Miss=-1.$%  TickCount=209  Tick=1218
    execute               Count= 18.1|15.5sec  DPE= 6220| 7%  DPET= 3769  DPR= 130.1  Miss=0.2%  Hit=3702  Crit= 8844|12942|49.1%
    heroic_strike         Count= 23.9|10.4sec  DPE= 4511| 7%  DPET=    1  DPR= 375.9  Miss=0.2%  Hit=2379  Crit= 5701| 5806|64.3%
    melee_main_hand       Count= 91.3| 3.3sec  DPE= 2975|17%  DPET= 1279  DPR=   0.0  Miss=0.2%  Hit=1962  Crit= 4245| 4340|49.6%  Glance=1472|23.7%
    mortal_strike         Count= 43.6| 6.7sec  DPE= 4530|12%  DPET= 2746  DPR= 151.0  Miss=0.2%  Hit=2694  Crit= 6452| 6572|49.0%
    overpower             Count= 46.7| 6.3sec  DPE= 5510|16%  DPET= 4792  DPR=1101.9  Miss=0.1%  Hit=2313  Crit= 5535| 5653|99.3%
    rend                  Count= 14.0|21.7sec  DPE= 7901| 7%  DPET= 4786  DPR= 790.1  Miss=0.2%  TickCount=96  Tick=1152
    slam                  Count= 57.4| 4.3sec  DPE= 4026|14%  DPET= 2440  DPR= 268.4  Miss=0.2%  Hit=2390  Crit= 5725| 5842|49.2%

Gains:

    Warrior_T7_MS_Orig:
        anger_management=87.7  (overflow=12.2%)
        avoided_attacks=3.9
        bloodrage=135.8  (overflow=9.5%)
        mh_attack=3591.3  (overflow=23.0%)
        sudden_death=3.7

    Warrior_T7_MS_2ptImpExec:
        avoided_attacks=3.9
        bloodrage=90.9  (overflow=9.1%)
        mh_attack=3731.5  (overflow=20.5%)
        sudden_death=8.8

    Warrior_T7_18_53_00:
        avoided_attacks=47.2
        berserker_rage=125.1  (overflow=4.1%)
        bloodrage=153.7  (overflow=2.5%)
        glyph_of_heroic_strike=507.9
        mh_attack=1276.4  (overflow=4.7%)
        oh_attack=2656.6  (overflow=8.5%)
        unbridled_wrath=141.8  (overflow=10.1%)

Procs:

    Warrior_T7_MS_Orig:
        sudden_death=10.4|28.78sec
        taste_for_blood=48.5|6.18sec

    Warrior_T7_MS_2ptImpExec:
        sudden_death=10.2|29.41sec
        taste_for_blood=48.5|6.18sec

    Warrior_T7_18_53_00:
        bloodsurge=23.8|12.59sec
        darkmoon_greatness=7.0|42.77sec
        mirror_of_truth=5.0|59.77sec

Up-Times:

    Global:
        100.0% : blood_frenzy
        100.0% : mangle
        100.0% : master_poisoner
        100.0% : savage_combat
        100.0% : totem_of_wrath
        100.0% : trauma

    Warrior_T7_MS_Orig:
        54.9% : berserking_mh
        20.8% : heroic_strike
        12.2% : rage_cap

    Warrior_T7_MS_2ptImpExec:
        55.0% : berserking_mh
        20.1% : heroic_strike
        11.1% : rage_cap

    Warrior_T7_18_53_00:
        55.8% : berserking_mh
        29.6% : berserking_oh
        87.7% : flurry
        72.6% : heroic_strike
         5.2% : rage_cap

Waiting:
     0.6% : Warrior_T7_MS_Orig
     0.7% : Warrior_T7_MS_2ptImpExec
    27.1% : Warrior_T7_18_53_00

Baseline Performance:
  TotalEvents   = 5133041
  MaxEventQueue = 36
  SimSeconds    = 299713
  CpuSeconds    = 8
  SpeedUp       = 37464



#42 Jayde

Jayde

    Great Tiger

  • Members
  • 766 posts

Posted 21 April 2009 - 01:54 PM

Would it make sense to add criteria similar to Moonkin Druids in regard to the remaining window until the next Taste for Blood refresh (every 6 seconds). (Moonkin have checks such as +=/moonfire,eclipse_left>=10)

For instance, I would say that generally speaking Mortal Strike would logically have priority over Overpower if Taste for Blood had just proc'd and MS is off cooldown, as there is no danger of losing the window of opportunity for Overpower until the proc is due to refresh. Doing Overpower -> MS vs. MS -> Overpower isn't going to change opportunity time for Overpower (provided you use it within the GCD + lag time of the buff refreshing), but it will reduce the opportunity time of MS due to delaying the cooldown refresh.

#43 Rallik

Rallik

    Piston Honda

  • Members
  • 148 posts

Posted 22 April 2009 - 03:50 AM

Ok, I just wasn't using the T8 globals file, silly me. Here's what I get with your original and my "better" arms spec, including the imp.execute change I outlined above. Seems that the heroic strike critting has a bigger impact than imp.exec. I wonder if something is wrong or if that is really how it is.


That's how it really is. Imp execute is a pretty bad talent all in all, and Incite destroys it. There's just a lot of lazy/bad/uninformed Arms warriors who think you're not supposed to use HS as Arms for some mystical reason, spread a lot of misinformation about Incite being bad, and you end up with the whole population thinking it's actually true.

#44 Tankietka

Tankietka

    Piston Honda

  • Members
  • 118 posts

Posted 22 April 2009 - 01:39 PM

That's how it really is. Imp execute is a pretty bad talent all in all, and Incite destroys it.


Well, I must disagree. Mainly because you generalise too much assuming everyone has the same/similar very good gear. In fact value of several talents changes together with gear - the better items you have the better some talents become while effectiveness of other lowers.

In case we have here (ImpExecute vs Incite) ImpExecute is better than Incite if you do not have good enough gear to use HS frequently.

#45 Rallik

Rallik

    Piston Honda

  • Members
  • 148 posts

Posted 22 April 2009 - 04:54 PM

Well, I must disagree. Mainly because you generalise too much assuming everyone has the same/similar very good gear. In fact value of several talents changes together with gear - the better items you have the better some talents become while effectiveness of other lowers.

In case we have here (ImpExecute vs Incite) ImpExecute is better than Incite if you do not have good enough gear to use HS frequently.


Naxx gear + raid buffs is more than enough to put incite far ahead. I don't think SimCraft is designed to model players in greens/blues and DPS output in heroics.

#46 tripp6sic6

tripp6sic6

    Von Kaiser

  • Members
  • 31 posts

Posted 23 April 2009 - 10:19 AM

The number of Sudden Death procs seems low in jlassila's results and in my own, unless I misunderstand the mechanics of Sudden Death.

In jlassil's results, there is an average of 309 melee attacks with a roughly 0.02% miss chance, which means that almost all melee attacks were hits. There were an average of 10.2 Sudden Death procs. 10.2 / 309 is roughly 3.3%

#47 Jayde

Jayde

    Great Tiger

  • Members
  • 766 posts

Posted 23 April 2009 - 03:00 PM

The number of Sudden Death procs seems low in jlassila's results and in my own, unless I misunderstand the mechanics of Sudden Death.

In jlassil's results, there is an average of 309 melee attacks with a roughly 0.02% miss chance, which means that almost all melee attacks were hits. There were an average of 10.2 Sudden Death procs. 10.2 / 309 is roughly 3.3%


Hmm.. in looking at the code, I'm not 100% familiar with how simulationcraft is set up but I did notice that sudden death is only being triggered at the bottom of the melee hit code. This means it would only proc off melee_main_hand and heroic_strike entries, not every instant attack.

The proc rate seems consistant with those numbers, if that's the case.

That said, I'm not certain it is. Looking at WWS from last night, I'm seeing things like:

0:39'12.563 Jayde melee swing hits Molten Colossus #1 for 3154 Physical. (Critical) #84595
0:39'13.625 Jayde Execute hits Molten Colossus #1 for 6871 Physical. (Critical) #84773
0:39'13.625 Jayde Sudden Death was removed from Jayde. #84774
0:39'13.984 Jayde gains Sudden Death. #84825
0:39'14.391 Molten Colossus #1's Deep Wounds is refreshed. #84874
0:39'14.828 Jayde Overpower hits Molten Colossus #1 for 4903 Physical. (Critical) #84955
0:39'14.969 Jayde melee swing hits Molten Colossus #1 for 1385 Physical. (Glancing) #84977


It seems unlikely that, even with lag, that Sudden Death proc would have been caused by the melee swing 1 second later or 1.4s before.

Also, something like this sequence (Other gains, DoT ticks, etc. clipped out)

0:42'17.984 Jayde melee swing hits Magma Rager #1 for 3184 Physical. (Critical) #99536
0:42'18.797 Jayde Slam hits Magma Rager #1 for 1902 Physical. #99688
0:42'19.172 Jayde gains Sudden Death. #99737
0:42'19.625 Jayde Overpower hits Magma Rager #1 for 4149 Physical. (Critical) #99796
0:42'21.219 Jayde Mortal Strike hits Magma Rager #1 for 5078 Physical. (Critical) #100047
0:42'21.422 Jayde melee swing hits Magma Rager #1 for 1361 Physical. #100070


Seems clear that, at the very least, my Slam or Overpower (Sudden Death applications seem a bit strange in terms of almost always happening 0.3s before or after an attack in the combat log--can't tell which from my current samples) and not any of my swings.

Another example shows:

0:42'54.547 Jayde Heroic Strike hits Magma Rager #2 for 5488 Physical. (Critical) #103819
0:42'54.938 Jayde Mortal Strike hits Magma Rager #2 for 6092 Physical. (Critical) #103869
0:42'55.719 Magma Rager #2's Deep Wounds is refreshed. #103949
0:42'56.531 Jayde Sudden Death was removed from Jayde. #104066
0:42'56.547 Jayde Execute hits Magma Rager #2 for 8148 Physical. (Critical) #104086
0:42'56.969 Jayde gains Sudden Death. #104140
-End of Fight-
0:43'06.953 Jayde Sudden Death was removed from Jayde. #104612


Seems to make it clear that Execute can proc Sudden Death as well.

So, it would seem the proc roll should exist in warrior_attack_t::execute rather than melee_t::execute. (I could be wrong about this though, but quick browsing of the code seems to suggest that.)

#48 dedmonwakeen

dedmonwakeen

    Bald Bull

  • Members
  • 1,302 posts

Posted 23 April 2009 - 04:13 PM

So, it would seem the proc roll should exist in warrior_attack_t::execute rather than melee_t::execute. (I could be wrong about this though, but quick browsing of the code seems to suggest that.)


Infers possible bug based upon high-level reports.
Confirms bug via careful (and multiple) WWS parses.
Finds bug in source and suggests alternative.

Pinch me! I'm dreaming!

In all seriousness, detailed contributions like this help immeasurably. Ping me if you want to take it that final step and commit the change yourself. Thorough analysis is the fastest way to get me to hand out commit access.....

#49 tripp6sic6

tripp6sic6

    Von Kaiser

  • Members
  • 31 posts

Posted 23 April 2009 - 08:00 PM

I also noticed in the code that the double-dibbing of Enrages (Wrecking Crew, Death Wish) for Deep Wounds hasn't been fixed.

I tested it earlier today and it doesn't appear to be happening in 3.1. I don't have a parse however. I can work on one if that's needed to make the change.

#50 Starfox

Starfox

    King Hippo

  • Members
  • 578 posts

Posted 23 April 2009 - 08:25 PM

I also noticed in the code that the double-dibbing of Enrages (Wrecking Crew, Death Wish) for Deep Wounds hasn't been fixed.

I tested it earlier today and it doesn't appear to be happening in 3.1. I don't have a parse however. I can work on one if that's needed to make the change.


Oh nice, just tested it, seems to be fixed in 3.1.1. Thanks for the find

Added a run of the sim with the fixed deep wounds and added fancy chart graphics!
Hello.
Light the fuse.
For all my homies.
Do not run, we are your friends.
SimulationCraft Druid Guy

#51 tripp6sic6

tripp6sic6

    Von Kaiser

  • Members
  • 31 posts

Posted 24 April 2009 - 08:00 AM

Not sure if I should post this here or on the Google Code site, but would changing this in the source and removing trigger_sudden_death( this ); from the auto-attack code produce the desired Sudden Death change or will it then effect Rend, as well? If that would make it apply to Rend, would that code need to be added to all abilities that can apply Sudden Death individually? I've never coded in C++ and am trying to get my feet wet on how Simulationcraft is coded, so please bear with me.
void warrior_attack_t::execute()
{
  attack_t::execute();
  event_t::early( player -> expirations.tier7_4pc );

  warrior_t* p = player -> cast_warrior();

[B]  if( result_is_hit() )
    trigger_sudden_death( this );[/b]

  if( result == RESULT_CRIT )
  {
    // Critproccgalore
    trigger_deep_wounds( this );
    trigger_rampage( this );
    trigger_wrecking_crew( this );
    trigger_trauma( this );
    if( p -> talents.flurry ) 
    {
      p -> aura_gain( "Flurry (3)" );
      p -> _buffs.flurry = 3;
    }
  }
  else if( result 
RESULT_DODGE ) { trigger_overpower_activation( this ); } else if( result
RESULT_PARRY ) { if( p -> glyphs.overpower && ( ! sim -> P309 || sim -> roll( 0.50 ) ) ) { trigger_overpower_activation( this ); p -> _procs.glyph_overpower -> occur(); } } if( p -> _buffs.recklessness > 0 && special ) p -> _buffs.recklessness--; }


#52 Jayde

Jayde

    Great Tiger

  • Members
  • 766 posts

Posted 24 April 2009 - 10:53 AM

Rend does inherit from warrior_attack_t and calls warrior_attack_t::execute() so it would appear to have a chance of triggering on the initial application of Rend if it was placed there as you did. (Which isn't correct.)

Most likely warrior_attack_t should be extended to have a bool for tracking if it's a 'weapon damage' attack for the purposes of triggering procs. (The crit procs currently get away with it, I guess, because Rend can't crit!)

I would think this will be needed to properly model Berserking as well. (There's probably a question as to if SimulationCraft should deal with this, but I would imagine that due to the nature of on-hit mechanics on the uptime of our 'staple' enchant, it would make sense to attempt to do this. It's not quite so easy to model as an average gear-based constant when you have things like Flurry and variable numbers of weapon attacks greatly changing the uptime.)

Again, a bit of grain of salt since I haven't had quite enough time to review the code fully.

#53 Starfox

Starfox

    King Hippo

  • Members
  • 578 posts

Posted 24 April 2009 - 11:23 AM

So every hit can trigger SD? Even aoe attacks like WW, Bladestorm? Didn't know that :/
Hello.
Light the fuse.
For all my homies.
Do not run, we are your friends.
SimulationCraft Druid Guy

#54 tripp6sic6

tripp6sic6

    Von Kaiser

  • Members
  • 31 posts

Posted 24 April 2009 - 11:40 AM

I'm 90% sure that Bladestorm can trigger Sudden Death. The only reason I'm not 100% is that white strikes could have made it appear that way. I'll have time later today to test that. If Bladestorm hits can trigger it, my assumption would be that Whirlwind can, as well, since Bladestorm only triggers the Whirlwind ability every second.

Would this line used in the Deep Wounds code (or a variation of it) provide the desired results?

assert( a -> weapon != 0 );

#55 Starfox

Starfox

    King Hippo

  • Members
  • 578 posts

Posted 24 April 2009 - 11:48 AM

I'm 90% sure that Bladestorm can trigger Sudden Death. The only reason I'm not 100% is that white strikes could have made it appear that way. I'll have time later today to test that. If Bladestorm hits can trigger it, my assumption would be that Whirlwind can, as well, since Bladestorm only triggers the Whirlwind ability every second.

Would this line used in the Deep Wounds code (or a variation of it) provide the desired results?

assert( a -> weapon != 0 );


Pushed the changes in r2254, SD triggers on every ::execute() but checks if the action dealt direct_dmg > 0.
This filters out attacks like Rend and Deep Wounds.
Hello.
Light the fuse.
For all my homies.
Do not run, we are your friends.
SimulationCraft Druid Guy

#56 Jayde

Jayde

    Great Tiger

  • Members
  • 766 posts

Posted 24 April 2009 - 12:46 PM

Pushed the changes in r2254, SD triggers on every ::execute() but checks if the action dealt direct_dmg > 0.
This filters out attacks like Rend and Deep Wounds.


Cool, interested to see how that affects the results and cycles when I get home. :)

I'm still guessing that having some kind of tiered priority for Overpower would have a large impact on results.

e.g. if you look at the 6s timer between refreshes and have something like: (ignoring other stuff in-between, of course)
actions+=/overpower,overpower_left<2
actions+=/mortal_strike
actions+=/overpower

In theory, that should increase DPS by optimizing both the MS and Overpower cooldowns. You could also place Sudden Death procs before non-expiring Overpowers to minimize the chance of buff overwriting without lowering Overpower DPS.

#57 Starfox

Starfox

    King Hippo

  • Members
  • 578 posts

Posted 24 April 2009 - 04:30 PM

Cool, interested to see how that affects the results and cycles when I get home. :)

I'm still guessing that having some kind of tiered priority for Overpower would have a large impact on results.

e.g. if you look at the 6s timer between refreshes and have something like: (ignoring other stuff in-between, of course)
actions+=/overpower,overpower_left<2
actions+=/mortal_strike
actions+=/overpower

In theory, that should increase DPS by optimizing both the MS and Overpower cooldowns. You could also place Sudden Death procs before non-expiring Overpowers to minimize the chance of buff overwriting without lowering Overpower DPS.


Ah, didn't change the profile in the second post, I have MS > Overpower, but yea, some options would perhaps be helpful.
chardev.org v6 ~ a World of Warcraft character planner somewhat BiS for T7 Fury (pre-ulduar gear)?
Hello.
Light the fuse.
For all my homies.
Do not run, we are your friends.
SimulationCraft Druid Guy

#58 Excession

Excession

    Von Kaiser

  • Members
  • 36 posts

Posted 24 April 2009 - 11:42 PM

chardev.org v6 ~ a World of Warcraft character planner somewhat BiS for T7 Fury (pre-ulduar gear)?


Use for ranged, no question. Then try changing the chest to , helm to , and replace the expertise gem in the belt with strength. Not sure about Berserking on your offhand, probably try massacre as well.

#59 tripp6sic6

tripp6sic6

    Von Kaiser

  • Members
  • 31 posts

Posted 25 April 2009 - 10:54 PM

Interesting results. I tested the different weapon specializations in SimCraft by assuming Betrayer of Humanity was a different weapon type for equivalency.

SimulationCraft for World of Warcraft build 3.1.0 (iterations=1000, max_time=300, optimal_raid=1)

DPS Ranking:
  23203 100.0%  Raid
   6577  28.3%  Warrior_T7_55_08_08_S
   5711  24.6%  Warrior_T7_55_08_08_A
   5539  23.8%  Warrior_T7_55_08_08_M
   5403  23.3%  Warrior_T7_18_53_00

Player=Warrior_T7_18_53_00  DPS=5403.4 (Error=+/-12.6 Range=+/-633)  DPR=347.3  RPS=15.6/15.7  (rage)
  Core Stats:  strength=918  agility=607  stamina=1411  intellect=41  spirit=71  health=18509  mana=20
  Spell Stats:  power=0  hit=8.8%  crit=20.1%  penetration=0  haste=6.4%  mp5=0
  Attack Stats:  power=3471  hit=7.0%  crit=33.0%  expertise=6.3  penetration=12.9  haste=6.4%
  Defense Stats:  armor=1214
  Actions:
    bloodthirst           Count= 49.5| 5.9sec  DPE= 5209|16%  DPET= 3157  DPR= 173.6  Miss=0.0%  Hit=3169  Crit= 7213|10525|50.6%  Dodge=0.2%
    deep_wounds           Count=  0.0| 0.0sec  DPE=    1|15%  DPET=    1  DPR=   0.0  Miss=-1.$%  TickCount=216  Tick=1139
    execute               Count= 12.1| 3.1sec  DPE= 8081| 6%  DPET= 4897  DPR= 114.3  Miss=0.0%  Hit=4817  Crit=11066|14530|52.4%  Dodge=0.2%
    heroic_strike         Count= 91.6| 2.9sec  DPE= 3936|22%  DPET=    1  DPR= 328.0  Miss=0.0%  Hit=2417  Crit= 5493| 7293|49.5%  Dodge=0.2%
    melee_main_hand       Count= 39.8| 7.6sec  DPE= 2691| 7%  DPET= 1362  DPR=   0.0  Miss=17.2%  Hit=2087  Crit= 4286| 5666|49.7%  Glance=1561|23.5%  Dodge=0.2%
    melee_off_hand        Count=130.4| 2.3sec  DPE= 1643|13%  DPET=  796  DPR=   0.0  Miss=16.8%  Hit=1273  Crit= 2622| 3543|49.2%  Glance= 955|24.2%  Dodge=0.2%
    slam                  Count= 19.0|14.2sec  DPE= 4328| 5%  DPET= 2623  DPR= 288.5  Miss=0.0%  Hit=2657  Crit= 6033| 8131|49.7%  Dodge=0.2%
    whirlwind             Count= 70.8| 8.5sec  DPE= 3471|15%  DPET= 4207  DPR= 277.7  Miss=0.0%  Hit=2096  Crit= 4759| 7947|51.8%  Dodge=0.3%

Player=Warrior_T7_55_08_08_A  DPS=5710.9 (Error=+/-9.3 Range=+/-474)  DPR=445.4  RPS=12.8/12.9  (rage)
  Core Stats:  strength=955  agility=607  stamina=1467  intellect=41  spirit=71  health=19073  mana=20
  Spell Stats:  power=0  hit=8.8%  crit=20.1%  penetration=0  haste=6.4%  mp5=0
  Attack Stats:  power=3544  hit=7.0%  crit=33.0%  expertise=7.3  penetration=12.9  haste=6.4%
  Defense Stats:  armor=1214
  Actions:
    bladestorm            Count=  4.0|91.1sec  DPE=22621| 5%  DPET= 3625  DPR= 904.8  Miss=0.0%  TickCount=28  Tick=2041  CritTick=4408|5070|51.3%
    deep_wounds           Count=  0.0| 0.0sec  DPE=    1|15%  DPET=    1  DPR=   0.0  Miss=-1.$%  TickCount=208  Tick=1245
    execute               Count= 30.3| 9.7sec  DPE= 6052|11%  DPET= 3668  DPR= 156.4  Miss=1.0%  Hit=3561  Crit= 8517|14121|50.9%
    heroic_strike         Count= 22.0|11.5sec  DPE= 4719| 6%  DPET=    1  DPR= 393.3  Miss=1.0%  Hit=2472  Crit= 5930| 6782|65.7%
    melee_main_hand       Count= 94.5| 3.2sec  DPE= 3128|17%  DPET= 1344  DPR=   0.0  Miss=1.0%  Hit=2048  Crit= 4429| 5179|51.3%  Glance=1535|23.7%
    mortal_strike         Count= 39.2| 7.4sec  DPE= 4789|11%  DPET= 2902  DPR= 159.6  Miss=0.9%  Hit=2808  Crit= 6724| 7700|51.3%
    overpower             Count= 46.6| 6.3sec  DPE= 5710|16%  DPET= 4965  DPR=1142.0  Miss=1.0%  Crit= 5767| 6738|99.0%
    rend                  Count= 14.1|21.5sec  DPE= 7812| 6%  DPET= 4735  DPR= 781.2  Miss=0.9%  TickCount=96  Tick=1149
    slam                  Count= 49.3| 5.0sec  DPE= 4214|12%  DPET= 2554  DPR= 280.9  Miss=1.0%  Hit=2482  Crit= 5941| 6889|50.8%

Player=Warrior_T7_55_08_08_M  DPS=5538.9 (Error=+/-8.8 Range=+/-496)  DPR=432.9  RPS=12.8/12.9  (rage)
  Core Stats:  strength=955  agility=607  stamina=1467  intellect=41  spirit=71  health=19073  mana=20
  Spell Stats:  power=0  hit=8.8%  crit=20.1%  penetration=0  haste=6.4%  mp5=0
  Attack Stats:  power=3544  hit=7.0%  crit=33.0%  expertise=7.3  penetration=12.9  haste=6.4%
  Defense Stats:  armor=1214
  Actions:
    bladestorm            Count=  4.0|91.1sec  DPE=22254| 5%  DPET= 3565  DPR= 890.2  Miss=0.0%  TickCount=28  Tick=2154  CritTick=4440|5105|45.9%
    deep_wounds           Count=  0.0| 0.0sec  DPE=    1|14%  DPET=    1  DPR=   0.0  Miss=-1.$%  TickCount=214  Tick=1106
    execute               Count= 30.1| 9.7sec  DPE= 5893|11%  DPET= 3572  DPR= 152.5  Miss=0.9%  Hit=3757  Crit= 8542|14159|45.4%
    heroic_strike         Count= 21.6|11.7sec  DPE= 4628| 6%  DPET=    1  DPR= 385.7  Miss=1.0%  Hit=2617  Crit= 5945| 6800|61.2%
    melee_main_hand       Count= 94.8| 3.1sec  DPE= 3068|18%  DPET= 1318  DPR=   0.0  Miss=1.0%  Hit=2164  Crit= 4456| 5215|46.0%  Glance=1624|23.8%
    mortal_strike         Count= 39.2| 7.4sec  DPE= 4672|11%  DPET= 2832  DPR= 155.7  Miss=1.0%  Hit=2968  Crit= 6743| 7721|45.9%
    overpower             Count= 46.5| 6.3sec  DPE= 5599|16%  DPET= 4870  DPR=1119.9  Miss=1.0%  Hit=2546  Crit= 5779| 6756|95.2%
    rend                  Count= 14.1|21.5sec  DPE= 7809| 7%  DPET= 4734  DPR= 780.9  Miss=0.9%  TickCount=96  Tick=1149
    slam                  Count= 49.4| 5.0sec  DPE= 4118|12%  DPET= 2495  DPR= 274.5  Miss=1.0%  Hit=2623  Crit= 5958| 6908|45.6%

Player=Warrior_T7_55_08_08_S  DPS=6577.1 (Error=+/-59.5 Range=+/-2406)  DPR=489.8  RPS=13.4/13.6  (rage)
  Core Stats:  strength=955  agility=607  stamina=1467  intellect=41  spirit=71  health=19073  mana=20
  Spell Stats:  power=0  hit=8.8%  crit=20.1%  penetration=0  haste=6.4%  mp5=0
  Attack Stats:  power=3544  hit=7.0%  crit=33.0%  expertise=7.3  penetration=12.9  haste=6.4%
  Defense Stats:  armor=1214
  Actions:
    bladestorm            Count=  4.0|91.1sec  DPE=21195| 4%  DPET= 3396  DPR= 847.8  Miss=0.0%  TickCount=28  Tick=2050  CritTick=4222|4828|46.2%
    deep_wounds           Count=  0.0| 0.0sec  DPE=    1|15%  DPET=    1  DPR=   0.0  Miss=-1.$%  TickCount=198  Tick=1528
    execute               Count= 35.4| 8.2sec  DPE= 5583|10%  DPET= 3383  DPR= 144.5  Miss=1.0%  Hit=3563  Crit= 8087|13392|45.4%
    heroic_strike         Count= 27.9| 8.9sec  DPE= 4385| 6%  DPET=    1  DPR= 365.5  Miss=0.9%  Hit=2482  Crit= 5639| 6432|61.0%
    melee_main_hand       Count=187.5| 1.6sec  DPE= 2924|28%  DPET= 1266  DPR=   0.0  Miss=1.0%  Hit=2061  Crit= 4245| 4933|46.1%  Glance=1546|24.0%
    mortal_strike         Count= 38.2| 7.6sec  DPE= 4434| 9%  DPET= 2687  DPR= 147.8  Miss=1.0%  Hit=2816  Crit= 6399| 7303|45.9%
    overpower             Count= 46.7| 6.2sec  DPE= 5320|13%  DPET= 4626  DPR=1064.0  Miss=1.0%  Hit=2416  Crit= 5491| 6390|95.2%
    rend                  Count= 14.1|21.5sec  DPE= 7846| 6%  DPET= 4756  DPR= 784.6  Miss=0.8%  TickCount=96  Tick=1153
    slam                  Count= 45.4| 5.5sec  DPE= 3924| 9%  DPET= 2378  DPR= 261.6  Miss=1.1%  Hit=2490  Crit= 5660| 6534|46.1%

Gains:

    Warrior_T7_18_53_00:
        avoided_attacks=5.1
        bloodrage=154.5  (overflow=1.5%)
        glyph_of_heroic_strike=454.0
        mh_attack=1398.2  (overflow=2.8%)
        oh_attack=2658.9  (overflow=5.6%)

    Warrior_T7_55_08_08_A:
        anger_management=84.7  (overflow=14.8%)
        avoided_attacks=19.6
        bloodrage=135.9  (overflow=9.4%)
        mh_attack=3610.4  (overflow=28.4%)
        sudden_death=7.2

    Warrior_T7_55_08_08_M:
        anger_management=85.0  (overflow=14.6%)
        avoided_attacks=20.3
        bloodrage=136.1  (overflow=9.2%)
        mh_attack=3600.0  (overflow=27.3%)
        sudden_death=6.4

    Warrior_T7_55_08_08_S:
        anger_management=68.1  (overflow=31.6%)
        avoided_attacks=20.3
        bloodrage=96.8  (overflow=14.3%)
        mh_attack=3882.9  (overflow=58.6%)
        sudden_death=2.3

Procs:

    Warrior_T7_18_53_00:
        bloodsurge=24.1|12.40sec
        darkmoon_greatness=7.0|42.68sec
        mirror_of_truth=5.0|60.22sec

    Warrior_T7_55_08_08_A:
        darkmoon_greatness=7.0|42.67sec
        mirror_of_truth=4.8|61.97sec
        sudden_death=27.6|10.80sec
        taste_for_blood=48.3|6.17sec

    Warrior_T7_55_08_08_M:
        darkmoon_greatness=7.0|42.69sec
        mirror_of_truth=4.7|63.18sec
        sudden_death=27.6|10.79sec
        taste_for_blood=48.3|6.17sec

    Warrior_T7_55_08_08_S:
        darkmoon_greatness=7.0|42.65sec
        mirror_of_truth=4.9|60.51sec
        sudden_death=36.7|8.13sec
        sword_specialization=14.4|20.74sec
        taste_for_blood=48.4|6.17sec

Up-Times:

    Global:
        100.0% : blood_frenzy
        100.0% : mangle
        100.0% : master_poisoner
        100.0% : savage_combat
        100.0% : totem_of_wrath
        100.0% : trauma

    Warrior_T7_18_53_00:
        56.2% : berserking_mh
        30.9% : berserking_oh
        86.1% : flurry
        69.7% : heroic_strike
         3.4% : rage_cap

    Warrior_T7_55_08_08_A:
        58.2% : berserking_mh
        18.9% : heroic_strike
        14.9% : rage_cap

    Warrior_T7_55_08_08_M:
        58.3% : berserking_mh
        18.5% : heroic_strike
        14.6% : rage_cap

    Warrior_T7_55_08_08_S:
        67.7% : berserking_mh
        13.0% : heroic_strike
        31.7% : rage_cap

Waiting:
    27.9% : Warrior_T7_18_53_00
     0.5% : Warrior_T7_55_08_08_A
     0.5% : Warrior_T7_55_08_08_M
     0.3% : Warrior_T7_55_08_08_S

Baseline Performance:
  TotalEvents   = 6457344
  MaxEventQueue = 51
  SimSeconds    = 298632
  CpuSeconds    = 4
  SpeedUp       = 74658

I'm completely surprised by the order. Is the 6 second cooldown implemented on Sword spec? I also expected Mace spec to be better due to the improvement to Armor Pen for Arms.

EDIT: After looking at the code, it appears to be implemented correctly. Sword spec might just be that good.

EDIT2: I may have discovered something. Sword Specialization procs appear to be producing rage in the simulator. I will be testing this in a few minutes.

#60 Starfox

Starfox

    King Hippo

  • Members
  • 578 posts

Posted 25 April 2009 - 11:48 PM

Interesting results. I tested the different weapon specializations in SimCraft by assuming Betrayer of Humanity was a different weapon type for equivalency.

I'm completely surprised by the order. Is the 6 second cooldown implemented on Sword spec? I also expected Mace spec to be better due to the improvement to Armor Pen for Arms.

EDIT: After looking at the code, it appears to be implemented correctly. Sword spec might just be that good.

EDIT2: I may have discovered something. Sword Specialization procs appear to be producing rage in the simulator. I will be testing this in a few minutes.


I was told swordspec procs a normal mainhand hit and assumed it produces rage in that way.
Hello.
Light the fuse.
For all my homies.
Do not run, we are your friends.
SimulationCraft Druid Guy




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users