I can help with checking out EnhSim to see exactly what EnhSim is doing but I'd like to understand how to get the paperdoll stats out of SimC's output. Looking at Shaman_Enhancement
at the Shaman_Enhancement_T12H setup, I'm assuming the unbuffed stats are a good starting point. I do have some questions though.
By unbuffed, do you mean the stats are only from gear and base stats? So this does not include any raid buffs, I assume given the Raid-Buffed column. But does this include buffs given from the shaman themselves, like Strength of Earth totem or Windfury totem? How about personal buffs like the armor type bonus or Flametongue Weapon? How about buffs based on talents like Unleashed Rage? What about primary talents like the melee hit bonus from Dual Wield? Does the Raid-Buffed column include debuffs like Critical Mass or does it only include direct buffs to the player?
The reason I'm asking this is because I can't make much sense of the Raid-Buffed column compared to the Unbuffed column. For example, the Mana for Raid-Buffed is listed as 25595 but for Unbuffed it's listed as 25490. So where is the 2126 mana buff from Arcane Brilliance? Melee Haste is listed as 7.25% for both columns, but where is the 10% melee haste buff from Windfury totem? I see Spell Haste go up by 5.37% from Unbuffed to Raid-Buffed. I assume that the 5% is from raid buffs like Moonkin Form, but where is the extra 0.37% coming from?
I'm assuming this is all just the way the Stats section is displayed but I'd like to get a sense of it so I can do an apples-to-apples comparison between the two sims.
In saying all that, I've been staying on the sideline watching this discussion between SimC and Rouncer. I really like that you are trying to look at the Enhancement shaman's priority list in a completely new way, and I think it's going to lead to better overall DPS both with or without the caster weapon. But there was two comments that I want to address:
Look, you don't fix a simulator by tweaking a single crude dial (EnhSim's "latency" setting) until you get the output you want. I submit that Simcraft has a very clear and explicitly defined relation to what we try to simulate, while EnhSim does not, it just tries to tailor certain details about its output to match WoL reports while not actually caring about the mechanics of how it arrives at that output.
Are you seriously suggesting that EnhSim doesn't care about how it implements it's mechanics? Especially when SimC has brought over some of the models I've worked on for EnhSim, like Flametongue Weapon
or Lava Lash
? I find it ironic in the same thread that states that SimC is going for +1/-1 damage variance, you find a bug where Static Shock is missing half its potential procs.
Both sims are attempting to simulate the blackbox that is WoW, as accurately as they can. Some of the mechanics are figured out via data-mining, which SimC has done a phenomenal job with. Some mechanics are figured out through in-game testing, like the Lava Lash example above. And some are just done with best-guesses based on combat log parses, like the ICD of Flametongue Weapon or the Fire Elemental cast mechanics. As inaccuracies are found in either sim, they will be fixed so we more accurately model what is happening on Live. Now, as Althor suggests earlier, is EnhSim's reactive cooldown based action model with a coarse reaction time accurate enough in a world of command queuing? Probably not, but I'd really have to sit down and think on the proper action model before proposing a solution in EnhSim. Especially since that area of the code is probably pre-Lich King. But calling out either sim as not caring about what it's simulating just distracts from the argument at hand, which is why isnâ€™t the proposed caster priority queue viable in a raid setting.
I do find it interesting throughout all this, that if I punch in an approximation of the two gear sets and priority queues into EnhSim-2.4.10 I see about a 1K+ damage increase with the caster set-up versus the melee set-up. So while the absolute numbers and PPM of each action don't match between the two sims, the potential of the new suggested priority queue with that gear seems pretty strong. As I get a fully matched up set of gear and stats from SimC, I'll post the two runs just for comparison purposes.
There was also this comment from above:
We did find a bug in EnhSim yesterday that was stopping LvB from being cast as often as it could be even if trying to hardcast.
I'm assuming from the comment that you found a bug or multiple bugs in the code itself. I never got a ticket or a PM though so I can't be sure what exactly you ran into. Now I did fix a problem with Lava Burst casting when it was interacting with the Flame Shock dot, Changelist # 59954
. But without knowing what build, config or source file you were looking at I canâ€™t be sure I fixed the problem you ran into. Could whoever found the bug in EnhSim go ahead and try EnhSim-2.4.10 and see if the problem still repros? In the future, if you run into any bugs in EnhSim please make sure you either enter a ticket or PM me. Especially if itâ€™s blocking you folks from doing some comparison work.
Finally, the enhancement shaman community is in the enviable position of having two completely viable simulators to test out rotations, gear setups, etc. As was stated earlier, this is not a competition between the two sims. Both sims have their own goals, theories and implementations. This diversity will allow the enhancement shaman community to come up with new gearing choices, priority setups and casting mechanics, and more importantly break out of established conventions and thought processes. So letâ€™s keep the focus on game mechanics and not the sims themselves.